Skip to content

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Dec 4, 2023

What does this PR do?

Fixes # (issue)
#5917

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Comment on lines 169 to 174
paths, checkpoint, old_checkpoint, attention_paths_to_split=None, additional_replacements=None, config=None
paths,
checkpoint,
old_checkpoint,
attention_paths_to_split=None,
additional_replacements=None,
config=None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the comma at the end, I think the formatting will be gone here. And we get to keep the LoC as is.

Comment on lines 389 to 394
checkpoint,
config,
path=None,
extract_ema=False,
controlnet=False,
skip_extract_state_dict=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Comment on lines 510 to 513
meta_path = {
"old": f"input_blocks.{i}.0",
"new": f"down_blocks.{block_id}.resnets.{layer_in_block_id}",
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Comment on lines 515 to 519
paths,
new_checkpoint,
unet_state_dict,
additional_replacements=[meta_path],
config=config,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Comment on lines 525 to 527
meta_path = {
"old": f"input_blocks.{i}.1",
"new": f"down_blocks.{block_id}.attentions.{layer_in_block_id}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Comment on lines 510 to 534
paths, new_checkpoint, unet_state_dict, additional_replacements=[meta_path], config=config
paths,
new_checkpoint,
unet_state_dict,
additional_replacements=[meta_path],
config=config,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the formatting related changes could be reverted.

@patrickvonplaten
Copy link
Contributor

@DN6 there seems to be something off with your linter as it's always changing every file that is adapted no?

@DN6
Copy link
Collaborator Author

DN6 commented Dec 4, 2023

@patrickvonplaten I fixed it. Think this branch was created before I applied the fix. Will resolve now

@DN6 DN6 merged commit 4c05f78 into main Dec 5, 2023
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 18, 2023
* fix

* fix ldm conversion

* fix linting
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* fix

* fix ldm conversion

* fix linting
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* fix

* fix ldm conversion

* fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants