[bug fix] Inpainting for MultiAdapter #5922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sayakpaul
reviewed
Nov 27, 2023
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thank you! Could you also add some fast tests here?
Contributor
Author
|
I am not sure how to do that, since I do not think I did it for #5869. Can you please illustrate me how to do it or point me in the right direction? |
Contributor
|
No tests needed here as it's a community pipeline - nice job @affromero :-) |
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* bug in MultiAdapter for Inpainting * adapter_input is a list for MultiAdapter --------- Co-authored-by: andres <[email protected]> Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes small bugs in PR #5869: when using multiple T2IAdapters for Inpainting.
adapter_conditioning_scalemust be a list, otherwise it raises a TypeError.adapter_inputmust be a list too, otherwise features is(channel, height, width), and not(batch, channel, height, width)Who can review?