Fixed custom module importing on Windows #5891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows use back slash and `os.path.join()` follows that convention.
sayakpaul
reviewed
Nov 27, 2023
Co-authored-by: Lucain <[email protected]>
|
@PENGUINLIONG could you take care of the code quality issues? |
|
The documentation is not available anymore as the PR was closed or merged. |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Fixed custom module importing on Windows Windows use back slash and `os.path.join()` follows that convention. * Apply suggestions from code review Co-authored-by: Lucain <[email protected]> * Update pipeline_utils.py --------- Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: Lucain <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Fixed custom module importing on Windows Windows use back slash and `os.path.join()` follows that convention. * Apply suggestions from code review Co-authored-by: Lucain <[email protected]> * Update pipeline_utils.py --------- Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: Lucain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current implementation doesn't import custom modules on Windows. Windows use back slash to separate directory hierarchies and
os.path.join()follows that convention, which is different from therfilenames extracted tofilenamesbefore.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?