Skip to content

[ldm3d] Ldm3d upscaler to community pipeline #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Nov 28, 2023
Merged

[ldm3d] Ldm3d upscaler to community pipeline #5870

merged 63 commits into from
Nov 28, 2023

Conversation

@estelleafl
Copy link
Contributor

@estelleafl estelleafl commented Nov 20, 2023 •
edited
Loading

Hi @patrickvonplaten,
Finally, I created a new PR for our contribution to the community pipelines. We can close the previous one (#5660)
Thank you for your help
Best

Aflalo and others added 30 commits June 18, 2023 04:52
fixed typo
471e5c1
updated doc to be consistent in naming
7f5edc5
make style/quality
5dddd0e
preprocessing for 4 channels and not 6
ec18756
make style
b6f1a7f
Merge branch 'main' of https://github.com/huggingface/diffusers into …
dc12b27 
…ldm3d_rgbd_4channels
test for 4c
d7348d6
make style/quality
ef923aa
Merge branch 'main' of https://github.com/huggingface/diffusers into …
7d58eb0 
…ldm3d_rgbd_4channels

 tests/pipelines/stable_diffusion/test_stable_diffusion_ldm3d.py
fixed test on cpu
3b242c3
Merge branch 'main' of https://github.com/huggingface/diffusers into …
e21f8e3 
…ldm3d_rgbd_4channels
fixed doc typo
a7249bf
changed default ckpt to 4c
1e5cabb
@estelleafl
Update pipeline_stable_diffusion_ldm3d.py
5d0b7e6
Merge branch 'main' of https://github.com/huggingface/diffusers into …
2da08c6 
…ldm3d_docs_fix
convert file
9d8bd99
Merge remote-tracking branch 'upstream/main' into convert_ckpt_file
a82d42f
ldm3d upscaler first commit
5ce1e7e
temp commit
1a3b3fd
ckpt conversion fix
1eab17d
upscaler from ldm3d
4aa1440
added ldm3d-hr
6ab7729
merge to upstream
40ef851
convert ckpts
442d604
doc ldm3d upscaler
65fc7f2
updated hr to sr
ef2d1e0
make style
a24bd3c
make style
00f0524
variable not defined bug
0546099
make style
717654b
@estelleafl estelleafl changed the title Ldm3d upscaler community [ldm3d] Ldm3d upscaler to community pipeline Nov 20, 2023
@estelleafl estelleafl mentioned this pull request Nov 20, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 20, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@estelleafl
Copy link
Contributor Author

estelleafl commented Nov 21, 2023

I am getting the error below when running make style/make quality.
I tried also from main and not on my branch and Im getting this error as well. Would you know why?

ruff check examples scripts src tests utils setup.py --fix
error: TOML parse error at line 16, column 1
|
16 | [tool.ruff.format]
| ^^^^^^^^^^^^^^^^^^
wanted exactly 1 element, more than 1 element

make: *** [Makefile:56: style] Error 2

patrickvonplaten
patrickvonplaten reviewed Nov 21, 2023
View reviewed changes
patrickvonplaten
patrickvonplaten reviewed Nov 21, 2023
View reviewed changes
patrickvonplaten
patrickvonplaten reviewed Nov 21, 2023
View reviewed changes
src/diffusers/image_processor.py
else:
raise Exception(f"This type {output_type} is not supported")

def preprocess(
Copy link
Contributor

@patrickvonplaten patrickvonplaten Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm is this really needed?

Copy link
Contributor Author

@estelleafl estelleafl Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the preprocess? or the raise?

Copy link
Contributor

@patrickvonplaten patrickvonplaten Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry I misread here, actually this look ok to me - @yiyixuxu wdyt?

Copy link
Collaborator

@yiyixuxu yiyixuxu Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah fine with me too!

patrickvonplaten
patrickvonplaten reviewed Nov 21, 2023
View reviewed changes
patrickvonplaten
patrickvonplaten approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me - @yiyixuxu wdyt?

src/diffusers/image_processor.py
else:
raise Exception(f"This type {output_type} is not supported")

def preprocess(
Copy link
Contributor

@patrickvonplaten patrickvonplaten Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry I misread here, actually this look ok to me - @yiyixuxu wdyt?

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Nov 27, 2023

I am getting the error below when running make style/make quality. I tried also from main and not on my branch and Im getting this error as well. Would you know why?

ruff check examples scripts src tests utils setup.py --fix error: TOML parse error at line 16, column 1 | 16 | [tool.ruff.format] | ^^^^^^^^^^^^^^^^^^ wanted exactly 1 element, more than 1 element

make: *** [Makefile:56: style] Error 2

can you try upgrading ruff?

pip install --upgrade ruff

@estelleafl
Copy link
Contributor Author

estelleafl commented Nov 28, 2023 •
edited
Loading

Thank you @patrickvonplaten and @yiyixuxu
I made style/quality following @yiyixuxu advice

@yiyixuxu yiyixuxu merged commit 5ae3c3a into huggingface:main Nov 28, 2023
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Nov 28, 2023

@estelleafl
merged! thank you :)

yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@estelleafl @patrickvonplaten @yiyixuxu
[ldm3d] Ldm3d upscaler to community pipeline (huggingface#5870)
b33303a 

---------
Co-authored-by: Aflalo <[email protected]>
Co-authored-by: Patrick von Platen <[email protected]>
Co-authored-by: YiYi Xu <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@estelleafl @patrickvonplaten @yiyixuxu
[ldm3d] Ldm3d upscaler to community pipeline (huggingface#5870)
7f12b4d 

---------
Co-authored-by: Aflalo <[email protected]>
Co-authored-by: Patrick von Platen <[email protected]>
Co-authored-by: YiYi Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxu yiyixuxu Awaiting requested review from yiyixuxu

1 more reviewer

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estelleafl @HuggingFaceDocBuilderDev @yiyixuxu @patrickvonplaten