-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Addition of new callbacks to controlnets #5812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yiyixuxu Could you let me know if the parameters like |
|
The documentation is not available anymore as the PR was closed or merged. |
|
Could you also let me know what to do with pipeline_controlnet_blip_diffusion.py? It did not support any callback parameters before, so I haven't added any new parameters either. |
|
Apart from controlnet pipelines, multiple other pipelines that support callbacks do not yet support the latest callback implementation. I'd be happy to work on adding those. |
Let's not add them for now! we can add them in the future when we get a feature request and need to support a meaningful user case :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! look great!
yes sure if you're happy to:) |
|
@patil-suraj There were a few merge conflicts after #5822. Could you verify if I've merged it correctly? |
|
Failing tests seem unrelated |
|
Great job @a-r-r-o-w |
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py * update callbacks * fix repeated kwarg * update --------- Co-authored-by: Patrick von Platen <[email protected]>
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py * update callbacks * fix repeated kwarg * update --------- Co-authored-by: Patrick von Platen <[email protected]>
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py * update callbacks * fix repeated kwarg * update --------- Co-authored-by: Patrick von Platen <[email protected]>
What does this PR do?
Fixes #5811, #5798
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@yiyixuxu @patrickvonplaten