Skip to content

Conversation

@a-r-r-o-w
Copy link
Contributor

What does this PR do?

Fixes #5811, #5798

Before submitting

Who can review?

@yiyixuxu @patrickvonplaten

@a-r-r-o-w
Copy link
Contributor Author

@yiyixuxu Could you let me know if the parameters like controlnet_conditioning_scale, control_guidance_start, control_guidance_end should also be @property-ified, like guidance_scale? Will add the changes to all pipelines accordingly?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 15, 2023

The documentation is not available anymore as the PR was closed or merged.

@a-r-r-o-w
Copy link
Contributor Author

Could you also let me know what to do with pipeline_controlnet_blip_diffusion.py? It did not support any callback parameters before, so I haven't added any new parameters either.

@a-r-r-o-w
Copy link
Contributor Author

Apart from controlnet pipelines, multiple other pipelines that support callbacks do not yet support the latest callback implementation. I'd be happy to work on adding those.

@yiyixuxu
Copy link
Collaborator

@a-r-r-o-w

Could you let me know if the parameters like controlnet_conditioning_scale, control_guidance_start, control_guidance_end should also be @property-ified, like guidance_scale? Will add the changes to all pipelines accordingly?

Let's not add them for now! we can add them in the future when we get a feature request and need to support a meaningful user case :)

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! look great!

@yiyixuxu
Copy link
Collaborator

Apart from controlnet pipelines, multiple other pipelines that support callbacks do not yet support the latest callback implementation. I'd be happy to work on adding those.

yes sure if you're happy to:)

@a-r-r-o-w
Copy link
Contributor Author

@patil-suraj There were a few merge conflicts after #5822. Could you verify if I've merged it correctly?

@a-r-r-o-w a-r-r-o-w changed the title Addition of new callbacks Addition of new callbacks to controlnets Nov 16, 2023
@a-r-r-o-w
Copy link
Contributor Author

Failing tests seem unrelated

@patrickvonplaten
Copy link
Contributor

Great job @a-r-r-o-w

@patrickvonplaten patrickvonplaten merged commit 8178088 into huggingface:main Nov 21, 2023
affromero pushed a commit to affromero/diffusers that referenced this pull request Nov 24, 2023
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py

* update callbacks

* fix repeated kwarg

* update

---------

Co-authored-by: Patrick von Platen <[email protected]>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py

* update callbacks

* fix repeated kwarg

* update

---------

Co-authored-by: Patrick von Platen <[email protected]>
@a-r-r-o-w a-r-r-o-w deleted the callbacks branch January 4, 2024 14:34
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py

* update callbacks

* fix repeated kwarg

* update

---------

Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Callbacks] adding callback_on_step_end arguments to all pipelines

4 participants