Speed up the peft lora unload #5741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Co-Authored-By: Younes Belkada <[email protected]>
There was a problem hiding this comment.
Thanks Sourab for making this work with the new PR on PEFT. I have some minor comments, no blockers.
For context, the mentioned PR is now merged and this change is necessary to work with PEFT main. We ran a test on OPT-350m, where we saw 15x speedup in unloading with the new changes.
Co-Authored-By: Benjamin Bossan <[email protected]>
younesbelkada
approved these changes
Nov 16, 2023
|
Thanks! |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Update peft_utils.py * fix bug * make the util backwards compatible. Co-Authored-By: Younes Belkada <[email protected]> * fix import issue * refactor the backward compatibilty condition * rename the conditional variable * address comments Co-Authored-By: Benjamin Bossan <[email protected]> * address comment --------- Co-authored-by: Younes Belkada <[email protected]> Co-authored-by: Benjamin Bossan <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Update peft_utils.py * fix bug * make the util backwards compatible. Co-Authored-By: Younes Belkada <[email protected]> * fix import issue * refactor the backward compatibilty condition * rename the conditional variable * address comments Co-Authored-By: Benjamin Bossan <[email protected]> * address comment --------- Co-authored-by: Younes Belkada <[email protected]> Co-authored-by: Benjamin Bossan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?