mps test fixes
#2470
Merged
mps test fixes
#2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mish op not yet supported.
They are too slow for fast CI.
|
The documentation is not available anymore as the PR was closed or merged. |
sayakpaul
approved these changes
Feb 24, 2023
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks!
I wonder if we could use the skip_mps decorator here.
Member
Author
I don't think so, because exclusion is based on device + pipeline_class - tests work on other pipelines. |
Member
Author
|
@sayakpaul I ended up using @skip_mps because other tests kept failing with the same pipeline. We can do a finer-grained analysis later. The failing test is because of #2468, so merging this now. |
Member
|
I see. Yeah let's take some time to test this in isolation. Happy to work with you some time next week on this. |
mengfei25
pushed a commit
to mengfei25/diffusers
that referenced
this pull request
Mar 27, 2023
* Skip variant tests (UNet1d, UNetRL) on mps. mish op not yet supported. * Exclude a couple of panorama tests on mps They are too slow for fast CI. * Exclude mps panorama from more tests. * mps: exclude all fast panorama tests as they keep failing.
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Skip variant tests (UNet1d, UNetRL) on mps. mish op not yet supported. * Exclude a couple of panorama tests on mps They are too slow for fast CI. * Exclude mps panorama from more tests. * mps: exclude all fast panorama tests as they keep failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/huggingface/diffusers/actions/runs/4214039605/jobs/7314220521