-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Make safety_checker optional in more pipelines #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Also, since the feature_extractor is a required argument for those pipelines, it should already display a nice error message about that no ? And think we can-not load feature_extractor automatically because those are associated with specific image models and might not be the same for all.
This is what it gives right now:
I think we could maybe improve it in a new PR. Merging this because I think fixing the issue is more important than the error message for those other pipelines :) |
|
Actually, taking a look at the test failures. |
…diffusers into fix-required-safety-checker
|
Tests now pass, cc @anton-l for the changes and merging to fix the issue. |
* Make safety_checker optional in more pipelines. * Remove inappropriate comment in inpaint pipeline. * InPaint Test: set feature_extractor to None. * Remove import * img2img test: set feature_extractor to None. * inpaint sd2 test: set feature_extractor to None. Co-authored-by: Suraj Patil <[email protected]>
Fixes #1792.
Note that some pipelines (paint by example, image variations) do require a
feature_extractor. We should at least display a clear error message if the loaded checkpoint doesn't have one. Or should we automatically instantiate one in those cases?