Remove all local telemetry #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| subfolder=subfolder, | ||
| revision=revision, | ||
| ) | ||
| send_telemetry( |
Contributor
There was a problem hiding this comment.
This we can and should leave IMO because it's when people download from the Hub so IP is exposed anyways
Member
Author
There was a problem hiding this comment.
The pipeline class is already sent via the hub request, so this call was redundant.
Contributor
There was a problem hiding this comment.
Ok all good then!
| ignore_patterns=ignore_patterns, | ||
| user_agent=user_agent, | ||
| ) | ||
| send_telemetry( |
Contributor
There was a problem hiding this comment.
This should stay as snapshot download is called anyways already
| ignore_patterns=ignore_patterns, | ||
| user_agent=user_agent, | ||
| ) | ||
| send_telemetry( |
Contributor
There was a problem hiding this comment.
this should stay because we're not in a local case here
patrickvonplaten
approved these changes
Dec 14, 2022
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Thanks for the quick PR!
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes v0.10.0's
send_telemetryfrom local pipeline loaders completely, leaving only the requested pipeline/model classes when loading them from the HF hub.