Skip to content

Conversation

@anton-l
Copy link
Member

@anton-l anton-l commented Dec 1, 2022

The values from Lightning configs aren't used durign training, so they might be wrong. E.g. v2-inference-v.yaml lists 64 instead of 96 for the UNet sample size: https://github.com/Stability-AI/stablediffusion/blob/main/configs/stable-diffusion/v2-inference-v.yaml#L13

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 1, 2022

The documentation is not available anymore as the PR was closed or merged.

)
parser.add_argument(
"--image_size",
default=512,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we default to None and have the script detect whether it's v2 or v1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But let's merge now, I'll add this later :-)

@patrickvonplaten patrickvonplaten merged commit e65b71a into main Dec 1, 2022
@patrickvonplaten patrickvonplaten deleted the ckpt-sample-size branch December 1, 2022 18:24
@d8ahazard
Copy link
Contributor

Dumb question, but does need to be accounted for when converting diffusers->sd checkpoint?

tcapelle pushed a commit to tcapelle/diffusers that referenced this pull request Dec 12, 2022
…1509)

* Add an explicit `--image_size` to the conversion script

* style
sliard pushed a commit to sliard/diffusers that referenced this pull request Dec 21, 2022
…1509)

* Add an explicit `--image_size` to the conversion script

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants