Speed up test and remove kwargs from call #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return_dict: bool = True, | ||
| callback: Optional[Callable[[int, int, torch.FloatTensor], None]] = None, | ||
| callback_steps: Optional[int] = 1, | ||
| **kwargs, |
Contributor
Author
There was a problem hiding this comment.
I think we forgot to remove them when removing a deprecated function arg. They are never used anywhere
|
|
||
| prompt = "hey" | ||
|
|
||
| output = sd_pipe(prompt, number_of_steps=1, output_type="np") |
Contributor
Author
There was a problem hiding this comment.
wrong naming here made the test super slow
patrickvonplaten
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
force-pushed
the
remove_kwargs_from_call_in_sd
branch
from
329128b to
3d99aa8
Compare
anton-l
approved these changes
Nov 28, 2022
Member
anton-l
left a comment
anton-l
left a comment
There was a problem hiding this comment.
LGTM, kwargs are only used in DDPMPipeline in this version 👍
sliard
pushed a commit
to sliard/diffusers
that referenced
this pull request
Dec 21, 2022
Remove kwargs from call
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
Remove kwargs from call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up the test by correcting the function argument and removes
kwargsfrom all pipelines which are never used