Skip to content

Conversation

@xenova
Copy link
Contributor

@xenova xenova commented Nov 14, 2022

Documentation says flip_sin_to_cos defaults to False, when it actually defaults to True

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@kashif
Copy link
Contributor

kashif commented Nov 14, 2022

LGTM! Thanks!

@xenova
Copy link
Contributor Author

xenova commented Nov 14, 2022

@kashif No worries. Also, while going through other documentation, I've noticed a few inconsistencies (different descriptions for the same thing) and a lot of duplicate descriptions.

For example, norm_num_groups (https://github.com/huggingface/diffusers/search?q=norm_num_groups) has different descriptions for different methods, and some methods do not document it.

Is there perhaps any plan to somehow share these parameters among methods, so that we only need to change it in one place?

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@patrickvonplaten patrickvonplaten merged commit 57525bb into huggingface:main Nov 14, 2022
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants