Fix DDIM for eta>0 and a cpu generator #1215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
anton-l
commented
Nov 9, 2022
Comment on lines
+86
to
+89
| generator = torch.manual_seed(0) | ||
| # set eta > 0 to test the variance noise generation | ||
| image = ddim(generator=generator, eta=1.0, num_inference_steps=2, output_type="numpy").images | ||
| image_slice = image[0, -3:, -3:, -1] |
Member
Author
There was a problem hiding this comment.
This tests fails with a device mismatch without the proposed change
anton-l
requested review from
patil-suraj,
patrickvonplaten and
pcuenca
and removed request for
patil-suraj
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Member
|
MPS tests fail, do you want me to take a look? |
Member
Author
|
@pcuenca yeah, I think those accumulated over the past two days 😅 |
Co-authored-by: Suraj Patil <[email protected]>
Member
Author
|
Superseded by #1222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1189
Allows DDIM to still be used with a cpu generator and eta>0 in
DDIMPipeline