Skip to content

[tests] skip instead of returning. #11793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

[tests] skip instead of returning. #11793

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb2813d
skip instead of returning.
sayakpaul Jun 24, 2025
b76ea11
Merge branch 'main' into skip-better-2
sayakpaul Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/models/test_modeling_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2107,7 +2107,7 @@ def test_hotswapping_compiled_model_linear(self, rank0, rank1):
@parameterized.expand([(11, 11), (7, 13), (13, 7)]) # important to test small to large and vice versa
def test_hotswapping_compiled_model_conv2d(self, rank0, rank1):
if "unet" not in self.model_class.__name__.lower():
return
pytest.skip("Test only applies to UNet.")

# It's important to add this context to raise an error on recompilation
target_modules = ["conv", "conv1", "conv2"]
Expand All @@ -2117,7 +2117,7 @@ def test_hotswapping_compiled_model_conv2d(self, rank0, rank1):
@parameterized.expand([(11, 11), (7, 13), (13, 7)]) # important to test small to large and vice versa
def test_hotswapping_compiled_model_both_linear_and_conv2d(self, rank0, rank1):
if "unet" not in self.model_class.__name__.lower():
return
pytest.skip("Test only applies to UNet.")

# It's important to add this context to raise an error on recompilation
target_modules = ["to_q", "conv"]
Expand Down