Skip to content

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Jun 6, 2025

What does this PR do?

Only makes sense to have one after #11605. To run:

RUN_SLOW=1 RUN_COMPILE=1 pytest tests/models/ -k "test_compile_with_group_offloading".

Cc: @stevhliu do you think we should document this thing in our torch.compile() documentation section?

@sayakpaul sayakpaul requested review from DN6 and a-r-r-o-w June 6, 2025 05:04
@sayakpaul sayakpaul added performance Anything related to performance improvements, profiling and benchmarking torch.compile labels Jun 6, 2025
@DN6
Copy link
Collaborator

DN6 commented Jun 6, 2025

Looks good. We wouldn't need this specific command since the current -k "compile" will pick up the test since compile is in the name.

RUN_SLOW=1 RUN_COMPILE=1 pytest tests/models/ -k "test_compile_with_group_offloading"

@sayakpaul sayakpaul merged commit 16c955c into main Jun 6, 2025
29 checks passed
@sayakpaul sayakpaul deleted the offload-compile-tests branch June 6, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Anything related to performance improvements, profiling and benchmarking torch.compile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants