Skip to content

[CI] Add slow MPS tests #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 5, 2022
Merged

[CI] Add slow MPS tests #1104

merged 11 commits into from
Dec 5, 2022

Conversation

@anton-l
Copy link
Member

@anton-l anton-l commented Nov 2, 2022

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 2, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@anton-l
Copy link
Member Author

anton-l commented Nov 2, 2022

cc @pcuenca for the failing tests reference, feel free to take over the PR if you get to it first :)

@pcuenca
Copy link
Member

pcuenca commented Nov 7, 2022

I fixed a couple crashes I found in #1170. I can continue here :)

@pcuenca pcuenca mentioned this pull request Nov 7, 2022
Closed
@pcuenca
Copy link
Member

pcuenca commented Nov 7, 2022 •
edited
Loading

I made the failing tests pass. Some where about generators not being compatible with the mps device, in some cases I had to increase the tolerance. But in other cases the returned slices are completely different as in other devices, I'm not sure if it's because of the "warmup" bug why (I checked the warmup, it didn't help).

@pcuenca
Copy link
Member

pcuenca commented Nov 7, 2022

@anton-l I think this should be ready now :)

@pcuenca
Copy link
Member

pcuenca commented Nov 10, 2022

@anton-l I'll merge main and retest this so we can merge.

@anton-l
Copy link
Member Author

anton-l commented Nov 10, 2022

@pcuenca maybe we should make these tests nightly (+ manually triggered) for now? We only have one MPS runner and the fast tests queue will get blocked by slow tests

@pcuenca
Copy link
Member

pcuenca commented Nov 10, 2022

@pcuenca maybe we should make these tests nightly (+ manually triggered) for now? We only have one MPS runner and the fast tests queue will get blocked by slow tests

Sounds good!

@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Nov 16, 2022

@anton-l @pcuenca any updates here?

@anton-l anton-l merged commit cc22bda into main Dec 5, 2022
@anton-l anton-l deleted the slow-mps-tests branch December 5, 2022 11:09
tcapelle pushed a commit to tcapelle/diffusers that referenced this pull request Dec 12, 2022
@anton-l @pcuenca
[CI] Add slow MPS tests (huggingface#1104)
1c41255 
* [CI] Add slow MPS tests

* fix yml

* temporarily resolve caching

* Tests: fix mps crashes.

* Skip test_load_pipeline_from_git on mps.

Not compatible with float16.

* Increase tolerance, use CPU generator, alt. slices.

* Move to nightly

* style

Co-authored-by: Pedro Cuenca <[email protected]>
sliard pushed a commit to sliard/diffusers that referenced this pull request Dec 21, 2022
@anton-l @pcuenca @sliard
[CI] Add slow MPS tests (huggingface#1104)
0c47891 
* [CI] Add slow MPS tests

* fix yml

* temporarily resolve caching

* Tests: fix mps crashes.

* Skip test_load_pipeline_from_git on mps.

Not compatible with float16.

* Increase tolerance, use CPU generator, alt. slices.

* Move to nightly

* style

Co-authored-by: Pedro Cuenca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcuenca pcuenca Awaiting requested review from pcuenca

Assignees

@pcuenca pcuenca

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anton-l @HuggingFaceDocBuilderDev @pcuenca @patrickvonplaten