client: ignore rc_buffer clippy warning #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new lint popped up overnight, see rust-lang/rust-clippy#6044 The problem is that we do indeed want this structure. - The outer Arc allows us to clone in .send() without cloning the array. - The Vec allows us to add middleware at runtime. - The inner Arc-s allow us to implement Clone without sharing the vector with the parent. - We don't use a Mutex around the Vec here because adding a middleware during execution should be an error.
Fishrock123
added a commit
to Fishrock123/tide
that referenced
this pull request
Sep 27, 2020
The rc_buffer thing is similar to http-rs/surf#242
Fishrock123
added a commit
to Fishrock123/rust-clippy
that referenced
this pull request
Sep 27, 2020
This didn't display some types properly in the docs due the lack of code formatting. Also, refs for the caveat: rust-lang#6044 (comment) http-rs/surf#242
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Sep 27, 2020
lints: clarify rc_buffer and add caveats This didn't display some types properly in the docs due the lack of code formatting. Also, refs for the caveat: #6044 (comment) http-rs/surf#242 Fwiw I can't get `cargo test` to run, even on nightly. I get: ``` error[E0463]: can't find crate for `rustc_ast` ``` *Please keep the line below* changelog: none, nightly
jbr
pushed a commit
to http-rs/tide
that referenced
this pull request
Oct 3, 2020
The rc_buffer thing is similar to http-rs/surf#242
yoshuawuyts
pushed a commit
to http-rs/tide
that referenced
this pull request
Oct 15, 2021
The rc_buffer thing is similar to http-rs/surf#242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new lint popped up overnight, see
rust-lang/rust-clippy#6044
The problem is that we do indeed want this structure.