-
-
Notifications
You must be signed in to change notification settings - Fork 407
fix: Add regression tests for Heatmaps IndexError fix (PR #6438) #6708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6708 +/- ##
==========================================
+ Coverage 89.19% 89.22% +0.02%
==========================================
Files 332 332
Lines 71928 72041 +113
==========================================
+ Hits 64158 64275 +117
+ Misses 7770 7766 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I feel like the tests are too synthetic. Could we instead make a UI test that recreates the problem in #6232 |
|
I think we should replace the existing tests with a UI test. |
hoxbro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should verify that these tests fails, if we are running without the fix in #6438
Closes #6232
This PR adds tests to verify that IndexError is properly suppressed when mouse/tap events occur outside the bounds of categorical axes on plots like HeatMaps, preventing crashes when users hover/click outside the plots or on colorbars or legends.