Skip to content

Conversation

@Azaya89
Copy link
Contributor

@Azaya89 Azaya89 commented Oct 22, 2025

Closes #6232

This PR adds tests to verify that IndexError is properly suppressed when mouse/tap events occur outside the bounds of categorical axes on plots like HeatMaps, preventing crashes when users hover/click outside the plots or on colorbars or legends.

@Azaya89 Azaya89 self-assigned this Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (1005798) to head (25672c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6708      +/-   ##
==========================================
+ Coverage   89.19%   89.22%   +0.02%     
==========================================
  Files         332      332              
  Lines       71928    72041     +113     
==========================================
+ Hits        64158    64275     +117     
+ Misses       7770     7766       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Azaya89 Azaya89 requested a review from hoxbro October 22, 2025 15:18
@hoxbro
Copy link
Member

hoxbro commented Oct 23, 2025

I feel like the tests are too synthetic. Could we instead make a UI test that recreates the problem in #6232

@Azaya89
Copy link
Contributor Author

Azaya89 commented Oct 23, 2025

I feel like the tests are too synthetic. Could we instead make a UI test that recreates the problem in #6232

Are you suggesting I replace the tests with something like the MRE in #6232 or just add the UI tests to these ones already written?

@hoxbro
Copy link
Member

hoxbro commented Oct 23, 2025

I think we should replace the existing tests with a UI test.

@hoxbro hoxbro added this to the 1.22.0 milestone Oct 24, 2025
@hoxbro hoxbro modified the milestones: 1.22.0, 1.22.1 Oct 31, 2025
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify that these tests fails, if we are running without the fix in #6438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The pointerXY stream breaks on heatmaps with categorical kdims

3 participants