DTR-820: PP1 Variation for a Suspended Budget Payment Plan #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/views/PaymentPlanDetailsView.scala.html # test/controllers/AmendPlanEndDateControllerSpec.scala
| case None => Future.successful(updatedAnswers) | ||
| updatedAnswers <- planDetail.scheduledPaymentStartDate match { | ||
| case Some(paymentStartDate) => Future.fromTry(updatedAnswers.set(AmendPlanEndDatePage, paymentStartDate)) | ||
| case None => Future.successful(updatedAnswers) |
There was a problem hiding this comment.
Please replace case None => with case _ =>
| _ <- sessionRepository.set(updatedAnswers) | ||
| } yield { | ||
| val flag: Future[Boolean] = calculateShowAction(nddService, planDetail) | ||
| val showActions = Await.result(flag, 5.seconds) |
There was a problem hiding this comment.
Please remove Await.result
There was a problem hiding this comment.
This is removed and moved method call inside the for comprehension
|
|
||
| private def isSuspendPeriodActive(planDetail: PaymentPlanDetails): Boolean = { | ||
| (for { | ||
| suspensionStartDate <- planDetail.suspensionStartDate |
There was a problem hiding this comment.
Remove suspensionStartDate <- planDetail.suspensionStartDate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement PP1 Variation for a Suspended Budget Payment Plan
Additionally, covered missing user session cleanups and added a few unit tests.