EXUI-3066 - HALO-23226 dates times #2046
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… native Date methods to momentjs
chrisjones-hmcts
changed the title
chrisjones-hmcts
changed the title
1 task
Josh-HMCTS
approved these changes
Nov 21, 2025
Contributor
Josh-HMCTS
left a comment
Josh-HMCTS
left a comment
There was a problem hiding this comment.
Looks fine to me, i like the approach of using one method (moment) to do dates instead of using a few different ways across everything.
RiteshHMCTS
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See EXUI-3066, EXUI-3005, EXUI-3003
(Corresponding MC PR: hmcts/rpx-xui-webapp#4750)
Changes across these two PRs:
Updated the datetime-picker component to use a dual control pattern, using a localDisplayControl to display local time to the user for interacting with, which is synced to the existing dateControl for UTC storage, using momentj.s for conversions.
Also replaced manual (native JS date) timezone offset calculations which could be vulnerable to daylight savings transitions with explicit moment.js based conversions.