exui-3582-hidden fields filled data should be removed #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregs-cgi
reviewed
Nov 4, 2025
...-ui-toolkit/src/lib/shared/components/case-editor/case-edit-page/case-edit-page.component.ts
Outdated
Show resolved
Hide resolved
gregs-cgi
reviewed
Nov 4, 2025
projects/ccd-case-ui-toolkit/src/lib/shared/services/form/form-value.service.spec.ts
Outdated
Show resolved
Hide resolved
gregs-cgi
reviewed
Nov 4, 2025
projects/ccd-case-ui-toolkit/src/lib/shared/services/form/form-value.service.ts
Outdated
Show resolved
Hide resolved
gregs-cgi
previously approved these changes
Nov 6, 2025
connorpgpmcelroy
previously approved these changes
Nov 6, 2025
Contributor
connorpgpmcelroy
left a comment
connorpgpmcelroy
left a comment
There was a problem hiding this comment.
LGTM, pleased with change, hopefully it works
| import { CaseField, FieldTypeEnum } from '../../domain'; | ||
| import { FieldsUtils } from '../fields'; | ||
| import { FieldTypeSanitiser } from './field-type-sanitiser'; | ||
| import { AbstractControl } from '@angular/forms'; |
Contributor
There was a problem hiding this comment.
Very minor comment but direct imports should be below external imports ideally
RiteshHMCTS
dismissed stale reviews from connorpgpmcelroy and gregs-cgi
via
2378360
|
gregs-cgi
approved these changes
Nov 10, 2025
chrisjones-hmcts
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-3582
Change description
hiddent fields filled data should be removed
Does this PR introduce a breaking change? (check one with "x")