Added fix and test changes #2024
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-HMCTS
reviewed
Oct 16, 2025
| this.alertService.error(error.message); | ||
| this.errorNotifier.announceError(error); | ||
| this.router.navigate([`/cases/case-details/${cid}/tasks`]); | ||
| // EXUI-2730 - Added logic to prevent navigation to tasks while on a case details page |
Contributor
There was a problem hiding this comment.
This is probably fine for now, but i'm not sure how this will function once SRT is merged as the url will be different and include case_type and jurisdiction
|
RiteshHMCTS
previously approved these changes
Oct 24, 2025
Josh-HMCTS
previously approved these changes
Oct 27, 2025
connorpgpmcelroy
dismissed stale reviews from Josh-HMCTS and RiteshHMCTS
via
f640a6b
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2730
Change description
Removed nav to tasks on event trigger error unless not on case details page
Added tests to confirm logic
Does this PR introduce a breaking change? (check one with "x")