Skip to content

Ex UI 3521 remove mc darkly flags #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ex UI 3521 remove mc darkly flags #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64e7087
removed the use of the flag icpEnabled: 'icp-enabled'
olusegz07 Oct 9, 2025
d19e3f8
toolkit version update
olusegz07 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hmcts/ccd-case-ui-toolkit",
"version": "7.2.49",
"version": "7.2.50-remove-flag-icp-enabled",
"engines": {
"node": ">=18.19.0"
},
Expand Down
2 changes: 1 addition & 1 deletion projects/ccd-case-ui-toolkit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hmcts/ccd-case-ui-toolkit",
"version": "7.2.49",
"version": "7.2.50-remove-flag-icp-enabled",
"engines": {
"node": ">=18.19.0"
},
Expand Down
12 changes: 2 additions & 10 deletions ...t/src/lib/shared/components/palette/case-file-view/case-file-view-field.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ describe('CaseFileViewFieldComponent', () => {
mockCaseFileViewService.getCategoriesAndDocuments.and.returnValue(of(null));

mockLoadingService = createSpyObj<LoadingService>('LoadingService', ['register', 'unregister']);
mockabstractConfig = createSpyObj<AbstractAppConfig>('LoadingService', ['getIcpJurisdictions', 'getIcpEnable']);
mockabstractConfig = createSpyObj<AbstractAppConfig>('LoadingService', ['getIcpJurisdictions']);
mockabstractConfig.getIcpJurisdictions.and.returnValue('["ST_CIC", "IA"]');
mockabstractConfig.getIcpEnable.and.returnValue(true);
mockLoadingService.register.and.returnValue('loadingToken');
mockLoadingService.unregister.and.returnValue(null);

Expand All @@ -92,7 +91,7 @@ describe('CaseFileViewFieldComponent', () => {
{ provide: LoadingService, useValue: mockLoadingService },
{ provide: SessionStorageService, useValue: mockSessionStorageService },
{ provide: CaseNotifier, useValue: ['ST-CIC'] },
{ provide: AbstractAppConfig, useValue: mockabstractConfig },
{ provide: AbstractAppConfig, useValue: mockabstractConfig }

]
})
Expand Down Expand Up @@ -246,14 +245,7 @@ describe('CaseFileViewFieldComponent', () => {
expect(component.errorMessages).toEqual(errorMessagesFromElements);
});

it('should disable icp when config contains false', () => {
mockabstractConfig.getIcpEnable.and.returnValue(false);
fixture.detectChanges();
expect(component.icpEnabled).toBeFalsy();
});

it('should enable icp when config contains true', () => {
mockabstractConfig.getIcpEnable.and.returnValue(true);
fixture.detectChanges();
expect(component.icpEnabled).toBeTruthy();
});
Expand Down
2 changes: 1 addition & 1 deletion ...oolkit/src/lib/shared/components/palette/case-file-view/case-file-view-field.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class CaseFileViewFieldComponent implements OnInit, AfterViewInit, OnDest
// As there can be more than one intersecting role, if any acls are update: true
this.allowMoving = acls.some(acl => acl.update);
this.icp_jurisdictions = this.abstractConfig.getIcpJurisdictions();
this.icpEnabled = this.abstractConfig.getIcpEnable();
this.icpEnabled = true;
}

public ngAfterViewInit(): void {
Expand Down