Skip to content

Conversation

@auht
Copy link
Contributor

@auht auht commented Mar 4, 2024

No description provided.

@LPTK LPTK changed the base branch from new-definition-typing to mlscript March 11, 2024 08:21
@LPTK
Copy link
Contributor

LPTK commented May 17, 2024

Do you intend to fix the bug and merge this?

@LPTK
Copy link
Contributor

LPTK commented Aug 26, 2024

  • TODO: Guard this feature behind a flag.

@auht auht marked this pull request as ready for review September 27, 2024 13:00
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please just address the two comments and then let me merge it.

@LPTK LPTK merged commit 5841627 into hkust-taco:mlscript Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants