This repository was archived by the owner on Aug 3, 2020. It is now read-only.
Remove usage of lodash from lib code #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
This uses the same core-util-is module as used in helmetjs/hsts#1 for checking types. When not supporting pre node.js 0.12.x versions any more, this module can be removed and one can only rely on the native
utilin node.js / iojs.There was one usage of lodash
.mapfunction which now are replaced with plain higher order Array functions.Then, there was a lodash deep copy of objects. From what I could see this copy function only copy the config object which is pretty flat and holds only
StringandArrayvalues. I replaced this with a very simple shallow copy function instead. This shallow copy function only copy one level and only handle Arrays as special values. If a deep copy is wanted we could replace this with:Lodash are still present as a devDependency since its used in the tests.