Support for NDC Spec v0.1.0-rc.15 and nested object/array selection #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-chambers
force-pushed
the
support-sdk-v2
branch
from
2600df6 to
b2a3ad3
Compare
daniel-chambers
changed the title
daniel-chambers
force-pushed
the
support-sdk-v2
branch
from
c9f87d5 to
2d9b28e
Compare
sordina
reviewed
Feb 13, 2024
sordina
left a comment
sordina
left a comment
There was a problem hiding this comment.
Looks great. Mostly straight forward. Have a couple of questions/suggestions. Not sure about some of the edgecases around fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
ndc-typescript-sdkto v3.0.0 which brings support for the NDC Spec v0.1.0-rc.15. Note that this is a breaking change, so it will need to be used with the latest Hasura engine that supports the new spec for it to work.This spec revision (added to the rc.14 revision) adds support for nested object/array selection in the response. This allows callers to only return a subset of the function return type if they wish. It also introduces a new function calling convention that relies upon nested object field selection, as well as a change the mutations request/response types.
Query requests now are expected to query for a virtual column called
__valueand use nested object queries to select into that value. This virtual column exists on the virtual row that is returned that encapsulates the function return value.This PR also adds new unit tests to cover the execution of mutations.
JIRA: NDC-307