Remove type inference recursion limit #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the recursion limit placed on the type inference algorithm. Previously it could go 20 steps deep and then would throw an error. This limit was hit when inferring types when using the kubernetes API as a sample. Now we're removing it, as it was originally a debugging aid to quickly prevent "infinite" loops. In the current implementation it is not possible to get infinite loops as we'll have a stack overflow if we end up (through buggy behaviour) in an "infinite" loop.
The PR also updates the TypeScript SDK depended on to the latest version: v4.6.0