Fix some hlint warnings #2523
Merged
Fix some hlint warnings #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
approved these changes
Dec 24, 2021
There was a problem hiding this comment.
Looked through the changes.
There are 2 places where maybeToMonoid can be used, but that is more a possibility than even a note.
Simple enough. Even mostly trivial.
Looks like you really stuck to HLint suggestions. Thanks. This allows for me to advance the structural hlint agenda (haskell/actions#85) in the project.
That together with preview reviews in #2519 & the successful Ailrun review, seems good to merge.
|
Thank you very much 🎁 & Happy New Year's & Christmas holidays 🎄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting of hlint fixes from #2519