Skip to content

Drop build and CI support for GHC < 8.0 #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 6, 2022
Merged

Drop build and CI support for GHC < 8.0 #8079

merged 9 commits into from
Apr 6, 2022

Conversation

andreabedini
Copy link
Collaborator

@andreabedini andreabedini commented Apr 4, 2022 •
edited
Loading

Replaces #7534.

Todo

  • figure out the changes to the bootstrap plans.

Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@jneira jneira mentioned this pull request Apr 4, 2022
Closed
3 tasks
@jneira jneira linked an issue Apr 4, 2022 that may be closed by this pull request
RFC: Dropping build support for GHC < 8 #7531
Open
@jneira jneira mentioned this pull request Apr 4, 2022
Open
@andreabedini andreabedini requested a review from Mikolaj April 5, 2022 02:46
@andreabedini andreabedini marked this pull request as ready for review April 5, 2022 02:46
@andreabedini
Copy link
Collaborator Author

@Mikolaj can you have a look? Do I need to update the bootstrap files?

@jneira
Copy link
Member

jneira commented Apr 5, 2022

many thanks for the cleaning up, love the +42−1,253

Mikolaj
Mikolaj approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. No, I think it's enough if we update the bootstrap files before release (or earlier on request). That's in (an old portion of) the release checklist at https://github.com/haskell/cabal/wiki/Making-a-release

@robx robx mentioned this pull request Apr 5, 2022
Merged
3 tasks
robx
robx approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@robx robx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, and I like that this is a bit more limited in scope than #7534.

(Can't really speak to the backwards compatibility implications.)

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Apr 6, 2022
@andreabedini andreabedini force-pushed the andrea/ghc-death-panel branch from 2fde8c7 to 891af7e Compare April 6, 2022 15:07
@mergify mergify bot merged commit f72c86e into master Apr 6, 2022
@Mikolaj Mikolaj mentioned this pull request Apr 7, 2022
Merged
3 tasks
@andreabedini andreabedini deleted the andrea/ghc-death-panel branch April 23, 2022 04:05
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robx robx robx approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Dropping build support for GHC < 8
4 participants
@andreabedini @jneira @robx @Mikolaj