This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Fixed #94 (Add Bifunctor to Foundation) #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about the location of this (we don't have a precedent except from IsList which is in Internal for giving a compat layer). I think it should be just be available in the Prelude (Foundation) otherwise. Otherwise looking spot on what I expected |
|
Ok, changed pushed, let's wait for travis to validate 😀 |
|
looking good. just the test that needs to be fixed. |
|
Sorry guys, had no clue that you were using |
|
Good stuff |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wouldn't be surprised if this PR needs amending both in terms of coding convention and package hierarchy conventions 😉
I backported
Data.Bifunctorfrom base using CPP for GHC older than 4.8.0.