-
Notifications
You must be signed in to change notification settings - Fork 10k
[DNM/WIP] PSS: Add logic for initialising a new working directory with PSS. #37323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SarahFrench
wants to merge
51
commits into
pss/multistage-provider-download-experiment
Choose a base branch
from
pss/init-of-new-pss-workingdir
base: pss/multistage-provider-download-experiment
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DNM/WIP] PSS: Add logic for initialising a new working directory with PSS. #37323
SarahFrench
wants to merge
51
commits into
pss/multistage-provider-download-experiment
from
pss/init-of-new-pss-workingdir
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figuring the backend.
…saving to the dep locks file
At this point we're unable to download the providers only described by state
This isn't accurate after previous reordering!
…ion as input for getting providers. Use in experimental init and append values to existing deps lock file
…oviders are determined from config
…t of attempting to update the lockfile, keep record of incomplete providers inside init command struct
…ocks and merge those with any locks on file. This allows re-use of providers downloaded by `getProvidersFromConfig` in the same init command
…ssing version constraints
…provider download step. When downloading providers described only in the state then the provider may already be downloaded from a previous init (i.e. is recorded in the deps lock file) or downloaded during step 1 of provider download. The message here needs to cover both potential scenarios.
…r implied local) project
…ath for adding a state store for the first time
…igrating to (implied) local backend
…as passed some through
f3221a2
to
70a7741
Compare
…lue from `ValidateProviderConfig`
… in the backend state file
…nguish between state managers
…ong state manager
764650f
to
4ad9f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry