Skip to content

Add the output reference page and align with the other block titles #36934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025

Conversation

rkoron007
Copy link
Contributor

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@rkoron007 rkoron007 added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Apr 28, 2025
@rkoron007 rkoron007 self-assigned this Apr 28, 2025
@rkoron007 rkoron007 requested review from a team as code owners April 28, 2025 21:47
@@ -211,7 +211,7 @@
"routes": [
{ "title": "Overview", "path": "values" },
{ "title": "Input Variables", "path": "values/variables" },
{ "title": "Output Values", "path": "values/outputs" },
{ "title": "Output block", "href": "/terraform/language/block/output" },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this page here until we get to the point of making a new usage page (which may happen now with my variable block rewrites, but I'm not 100% yet)

@@ -1116,13 +1116,17 @@
"title": "Configuration blocks",
"routes": [
{
"title": "check",
"title": "Check block",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned this with the other two article names

@rkoron007 rkoron007 changed the title Align all the other block titles and add the output reference page Add the output reference page and align with the other block titles Apr 28, 2025
Copy link
Contributor

@robin-norwood robin-norwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with some suggestions.

@rkoron007 rkoron007 merged commit ba4191f into docs/reference-rewrites-phrase-1 Apr 29, 2025
8 checks passed
@rkoron007 rkoron007 deleted the RK/outputs branch April 29, 2025 21:09
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants