Adds tests for querycheck.ExpectNoIdentity
#564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdavison
force-pushed
the
f-querycheck-negative-checks-tests
branch
from
e08916f to
96e44b9
Compare
stephybun
reviewed
Oct 21, 2025
| } | ||
| } | ||
| `, | ||
| QueryResultChecks: []querycheck.QueryResultCheck{ |
There was a problem hiding this comment.
Should this test be expecting an error here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for #559, building on #553.
Similarly to
TestExpectIdentity_NotFound,TestExpectNoIdentity_Foundcurrently fails as there is no mechanism for expecting a failure inQuerytest steps until #561 is mergedRollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.