Fix TestRequestManager_RemoveStream race condition #4966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mur-me
approved these changes
Nov 18, 2025
Frozen
approved these changes
Nov 18, 2025
Frozen
pushed a commit
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestRequestManager_RemoveStream test was intermittently failing with an error indicating unexpected stream size (expected 2, got 3). This was caused by a race condition where the test checked the stream count immediately after removing a stream, but the removal event is processed asynchronously in the request manager's event loop. The fix adds a retry loop that waits up to 10 seconds for the stream removal to be fully processed before asserting the stream count, ensuring the asynchronous event has been handled before validation. This eliminates the flakiness and makes the test deterministic.