Skip to content

updated gencodec version to v0.1.1 #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

updated gencodec version to v0.1.1 #4948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0fe198
updated gencodec version to v0.1.1
Frozen Sep 19, 2025
13828ac
test: improve error messages for unexpected stream sizes in request m…
Frozen Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ install:
# - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.41.1
- make go-get
- go install golang.org/x/tools/cmd/[email protected]
- go install github.com/fjl/[email protected].0
- go install github.com/fjl/[email protected].1
- echo "[WARN] - workaround for the GOPATH:"
# sometimes Travis decides to respect GOPATH and creates a symlink, thus we have || true for such cases
- rm $GOPATH/src/github.com/harmony-one/harmony || true;
Expand Down
7 changes: 5 additions & 2 deletions p2p/stream/common/requestmanager/requestmanager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,11 @@ func TestRequestManager_RemoveStream(t *testing.T) {
t.Errorf("unexpected error: %v", errors.New("stream removed when doing request"))
}

if ts.rm.streams.Length() != 2 || ts.rm.available.Length() != 2 {
t.Errorf("unexpected stream size")
if l := ts.rm.streams.Length(); l != 2 {
t.Errorf("unexpected stream size, expected 2, got %d", l)
}
if l := ts.rm.available.Length(); l != 2 {
t.Errorf("unexpected stream size, expected 2, got %d", l)
}
}

Expand Down