Improve Stream Error Handling and Classification #4945
Draft
+1,232
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GheisMohammadi
force-pushed
the
improve/stream_error_classification
branch
2 times, most recently
from
0bb6aaf to
b4026c8
Compare
Collaborator
|
I personally like the direction of this PR, but, can we also have this logic as Prometheus metrics? 🙏 |
GheisMohammadi
force-pushed
the
improve/stream_error_classification
branch
from
b4026c8 to
b9c5100
Compare
GheisMohammadi
force-pushed
the
improve/stream_error_classification
branch
from
b9c5100 to
e6d8776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO