Remove unused code #2296
Merged
Remove unused code #2296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblok
force-pushed
the
remove-unsued-code
branch
2 times, most recently
from
2543d19 to
9bda16c
Compare
kblok
force-pushed
the
remove-unsued-code
branch
from
9bda16c to
3c7e852
Compare
jnyrup
reviewed
Aug 30, 2023
lib/PuppeteerSharp/WaitTask.cs
Outdated
Comment on lines
82
to
87
| if (_timeoutTimer?.Status == TaskStatus.RanToCompletion || | ||
| _timeoutTimer?.Status == TaskStatus.Faulted || | ||
| _timeoutTimer?.Status == TaskStatus.Canceled) | ||
| { | ||
| _timeoutTimer.Dispose(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (_timeoutTimer?.Status == TaskStatus.RanToCompletion || | |
| _timeoutTimer?.Status == TaskStatus.Faulted || | |
| _timeoutTimer?.Status == TaskStatus.Canceled) | |
| { | |
| _timeoutTimer.Dispose(); | |
| } | |
| if (_timeoutTimer is { Status: TaskStatus.RanToCompletion or TaskStatus.Faulted or TaskStatus.Canceled } timeoutTimer) | |
| { | |
| timeoutTimer.Dispose(); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Microsoft.CodeAnalysis.CSharp.CodeStyleto get some extra validations on build time.