Skip to content

Improve transport event listener #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Improve transport event listener #2287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/PuppeteerSharp/Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,18 @@ protected virtual void Dispose(bool disposing)
}

private async void Transport_MessageReceived(object sender, MessageReceivedEventArgs e)
=> await _callbackQueue.Enqueue(() => ProcessMessage(e)).ConfigureAwait(false);
{
try
{
await _callbackQueue.Enqueue(() => ProcessMessage(e)).ConfigureAwait(false);
}
catch (Exception exception)
{
// We could just catch ObjectDisposedException but as this is an event listener
// we don't want to crash the whole process.
_logger.LogError(exception, $"Failed to process message {e.Message}");
}
}

private async Task ProcessMessage(MessageReceivedEventArgs e)
{
Expand Down
8 changes: 4 additions & 4 deletions lib/PuppeteerSharp/PuppeteerSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
<Description>Headless Browser .NET API</Description>
<PackageId>PuppeteerSharp</PackageId>
<PackageReleaseNotes></PackageReleaseNotes>
<PackageVersion>11.0.0</PackageVersion>
<ReleaseVersion>11.0.0</ReleaseVersion>
<AssemblyVersion>11.0.0</AssemblyVersion>
<FileVersion>11.0.0</FileVersion>
<PackageVersion>11.0.1</PackageVersion>
<ReleaseVersion>11.0.1</ReleaseVersion>
<AssemblyVersion>11.0.1</AssemblyVersion>
<FileVersion>11.0.1</FileVersion>
<SynchReleaseVersion>false</SynchReleaseVersion>
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<DebugType>embedded</DebugType>
Expand Down