Investigate only piping the payload after a connection is established

[geek]

Relates to

wreck/lib/index.js

Lines 303 to 322 in 576ce9d

	if (payloadSupported) {
	if (options.payload instanceof Stream) {
	let stream = options.payload;
	if (redirects) {
	const collector = new Tap();
	collector.once('finish', () => {
	shadow = collector.collect();
	});
	stream = options.payload.pipe(collector);
	}
	stream.pipe(req);
	return req;
	}
	req.write(options.payload);
	}

[ggoodman]

When passing a readable stream as options.payload, the readable stream will be piped to the ClientRequest before a socket connection is established. That causes the stream to be put into the flowing mode meaning that the stream cannot be re-used in the event that no socket connection can be established.

Our work-around has been to pass a stream.PassThrough instance as options.payload and then to pipe the actual payload into the pass-through stream once a socket connection is established ('connect' event on the socket).

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.