Skip to content

Fix webpack browser install #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix webpack browser install #1844

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e5a580
Update package.json
stevemk14ebr Mar 23, 2022
a07645b
Update package.json
stevemk14ebr Mar 23, 2022
fd87c57
Update package.json
stevemk14ebr Mar 23, 2022
5b3d1ff
Update package.json
stevemk14ebr Mar 23, 2022
cce607d
Remove prepare script
stevemk14ebr Mar 23, 2022
adc1e44
remove coffeescript
stevemk14ebr Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,13 @@
"uglify-js": "^3.1.4",
"underscore": "^1.5.1",
"webpack": "^1.12.6",
"webpack-dev-server": "^1.12.1"
"webpack-dev-server": "^1.12.1",
"coffeescript": "^2.6.1",
Copy link
Member

@jaylinski jaylinski Mar 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add coffeescript as a dependency? The build doesn't seem to fail...

Please provide the error output.

Copy link
Author

@stevemk14ebr stevemk14ebr Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 ~/source/repos/tmp/aster/node_modules/handlebars  npm run build

> [email protected] build
> grunt build

Loading "bg-shell.coffee" tasks...ERROR
>> Error: Grunt attempted to load a .coffee file but CoffeeScript was not installed.
>> Please run `npm install --dev coffeescript` to enable loading CoffeeScript.
Loading "child-process.coffee" tasks...ERROR
>> Error: Grunt attempted to load a .coffee file but CoffeeScript was not installed.
>> Please run `npm install --dev coffeescript` to enable loading CoffeeScript.

Running "babel:cjs" (babel) task

Running "webpack:handlebars" (webpack) task
Version: webpack 1.15.0
        Asset    Size  Chunks             Chunk Names
handlebars.js  572 kB       0  [emitted]  main

Running "webpack:runtime" (webpack) task
Version: webpack 1.15.0
                Asset    Size  Chunks             Chunk Names
handlebars.runtime.js  383 kB       0  [emitted]  main

Done.

Copy link
Author

@stevemk14ebr stevemk14ebr Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the dependency so this can move forward. I'm probably doing something wrong, but that's the error I received, and why I added it. Works without errors with coffeescript.

},
"main": "lib/index.js",
"types": "types/index.d.ts",
"browser": {
".": "./dist/cjs/handlebars.js",
"./lib/index.js": "./dist/cjs/handlebars.js",
"./runtime": "./dist/cjs/handlebars.runtime.js"
},
"bin": {
Expand Down