Skip to content

Conversation

@krichter722
Copy link
Contributor

As suggested in #214 the checkstyle setup can be put forward step by
step in order to minimize controversy. The start contains a rule to
enforce a license header on every Java files which is a must-have.

@sf105
Copy link
Member

sf105 commented Aug 8, 2018

Sorry to put you through all this. I'm not sure I see the need to enforce that one. It seems to me that many projects have a short header that references the project licence.

@krichter722
Copy link
Contributor Author

@tumbarumba What do you think about the headers? Smaller headers are easier to handle, however most IDE will hide them anyway, so it won't make a difference.

@nhojpatrick
Copy link
Member

@krichter722 happy to look at getting merged, a huge boilerplate copyright text at the top of a file seams pointless, so personally would prefer shorter snipper just pointing to a LICENSE file in the root of the repo.

will aim get to get something merged by the end of summer...

please can you rebase from master, as hamcrest-core and hamcrest-library have been refactored a lot and also deprecated, so that everything is just in hamcrest.

@sf105
Copy link
Member

sf105 commented Jun 29, 2020

I agree with @nhojpatrick. We really don't need this kind of noise in a little library like Hamcrest

@krichter722 krichter722 changed the title Start checkstyle setup Checker header in checkstyle Mar 21, 2021
@nhojpatrick
Copy link
Member

Going to try and kick start hamcrest, so if you want to get it merged, please rebase from the branch v2.3-candidates.
Still trying to understand how has permissions to perform a release.

As suggested in #214 the checkstyle setup can be put forward step by
step in order to minimize controversy. The start contains a rule to
enforce a license header on every Java files which is a must-have.
@krichter722
Copy link
Contributor Author

Can't get checkstyle to work with Groovy-Gradle. The config and the headers are on the branch in case someone wants to take over.

@krichter722 krichter722 deleted the checkstyle-simple branch February 13, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants