Skip to content
This repository was archived by the owner on Jul 6, 2019. It is now read-only.

Conversation

farcaller
Copy link
Member

That is, ioreg, platformtree and macro code.

@farcaller farcaller changed the title Moved all rust code in src Moved all rust code into src Sep 2, 2014
@bharrisau bharrisau mentioned this pull request Sep 2, 2014
7 tasks
@bharrisau
Copy link
Contributor

Fast builds!

@farcaller
Copy link
Member Author

Yup, I looked at that 6sec build and actually went to ci.zinc.rs to verify that there was some building involved :-)

@farcaller
Copy link
Member Author

r anyone?

@farcaller
Copy link
Member Author

actually not anyone but specifically @bharrisau (due to crago work) and @bgamari (due to ioreg crate moves)

@bgamari
Copy link
Contributor

bgamari commented Sep 3, 2014

Looks good to me. I'll let @bharrisau give the r

@bharrisau
Copy link
Contributor

LGTM - Is there a reason we need the ioreg crate separate from the ioreg macro/plugin_registrar definition?

@bgamari
Copy link
Contributor

bgamari commented Sep 4, 2014

@bharrisau I did this modelling the platformtree code.

@farcaller
Copy link
Member Author

I've tried unifying macro_ioreg and macro_platformtree into one crate but than I've realised that ioreg is a zinc dependency and pt is end user code dependency, so there's little sense it that

farcaller added a commit that referenced this pull request Sep 4, 2014
@farcaller farcaller merged commit 46911c2 into hackndev:master Sep 4, 2014
@farcaller farcaller deleted the toss-code-around branch September 4, 2014 09:08
@bharrisau
Copy link
Contributor

@farcaller I meant having the platformtree crate separate from the
platformtree plugin registrar.

@farcaller
Copy link
Member Author

Uh.. I don't really know :-) might merge those two actually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants