Adding Error Messaging in Register Page #215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jgenso
reviewed
Nov 2, 2016
| error.foreach ( el => { | ||
| el match { | ||
| case email_id => | ||
| S.error("email_err", email_id.msg) |
There was a problem hiding this comment.
algo como S.error(el.id, el.msg) no funciona?
There was a problem hiding this comment.
Nope. id does not exist in el. at least, the compiler gives me that error message.
Anyway, I am checking one by one because I want to write message below the corresponding field/s. Or do you prefer to show error messages into only one container?
After reviewing the fields name and lastName, It is not mandatory to use a name or lastName for registering users.. they can be empty. Is that ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #163