This repository was archived by the owner on Aug 16, 2024. It is now read-only.
Reduce memory allocation by caching or reusing #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supercolbat
commented
Jan 16, 2024
| getState(): GameState // For weird backwards-compatibility reasons, not part of API | ||
| } | ||
|
|
||
| const SPRITE_CACHE_SIZE = 64; |
Author
There was a problem hiding this comment.
This value was chosen after determining that 16 and 32 didn't have a noticable impact.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visible result of these changes can only be seen on games that make heavy of use
setLegend. The memory-intensive blocks of code were found through the Firefox memory profiler.On Firefox, these games would suffer from high memory usage and lag spikes from garbage collection. The same does not occur on Chromium-based browsers.
sprig-engine-perf.mp4
Games tested in the screen recording: ROOM and Taiko Fever.
Firefox
ROOM on max resolution still lags and has occasional lockups even after these changes, because it's an absolute beast. When not run alongside 3 other RAM blackholes, Taiko Fever runs with very subtle lag spikes.
Chrome
ROOM on max resolution still lags sometimes but doesn't lock up for several seconds like before. Taiko Fever works great.