Render Wise transfers in the correct currency #11258
Conversation
app/views/events/transfers.html.erb
Outdated
| <td style="text-align: right;"> | ||
| <% if d.is_a? Wire %> | ||
| <% case d %> | ||
| <% when Wire %> | ||
| <%= render_money(d.local_hcb_code.amount_cents.abs) %> | ||
| <% when WiseTransfer %> | ||
| <% if d.currency == "USD" %> | ||
| <%= render_money(d.usd_amount || d.amount) %> | ||
| <% else %> | ||
| <% fx_tooltip = capture do %> | ||
| <% if d.usd_amount_cents %> | ||
| <%= render_money(d.usd_amount_cents) %> | ||
| <% elsif d.quoted_usd_amount_cents %> | ||
| Quoted <%= render_money(d.quoted_usd_amount_cents) %> | ||
| <% else %> | ||
| No USD amount | ||
| <% end %> | ||
| <% end %> | ||
|
|
||
| <span class="tooltipped tooltipped--w inline-block" aria-label="<%= fx_tooltip %>"> | ||
| <%= d.amount.format(with_currency: true) %> | ||
| </span> | ||
| <% end %> | ||
| <% else %> |
There was a problem hiding this comment.
I feel like the pattern should match the wire pattern?
There was a problem hiding this comment.
That was my first thought but I wasn't sure d.local_hcb_code.amount_cents would be populated.
- The only non-nullable field on
WiseTransferisamount_centswhich can be in any number of currencies and is populated when the transfer is created_centsis a misnomer as it technically stores subunits (e.g. JPY 1000 would be stored as 1000 as it is non-fractional)
quoted_usd_amount_cents(nullable) is populated after a call to the Wise API (but might change?)usd_amount_cents(nullable) is populated by ops when the transfer is processed
As far as I can tell we don't have any validation on the presence of either (3) or (4). quoted_usd_amount_cents is populated on creation and synced to the canonical pending transaction and subsequently replaced by usd_amount_cents (if present).
So in theory, we should be fine relying on the canonical pending transaction but
- I would like to see stronger validations for all of the above
- We would probably want to show the original currency (maybe in a tooltip) as that's what the user entered.
There was a problem hiding this comment.
+1 on validations but d.local_hcb_code.amount_cents should always be set. I'm cool with either product direction - @YodaLightsabr got thoughts? I'd just like us to be consistent with what we do for wires.
There was a problem hiding this comment.
I think I would prefer making the USD amount more prominent, but we should show the local amount in a tooltip. I will say that wherever we're rendering the USD amount, we should use the HCB code amount because that will always match the transaction amount on the ledger.
_cents is a misnomer as it technically stores subunits (e.g. JPY 1000 would be stored as 1000 as it is non-fractional)
This is true, however I believe this is the terminology used by the money-rails gem.
…al amount + currency
Summary of the problem
We are incorrectly rendering Wise transfer amounts in non-USD currencies as USD.
Describe your changes
Add special handling for Wise transfers: