-
Notifications
You must be signed in to change notification settings - Fork 444
OwOPad #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OwOPad #582
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cheyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Good job on making a hackpad! But you will need to make a few changes for it to be approved:
- Please add the kicad project files into the PCB folder!
- You probably need a plate for the keyboard!
Else LGTM #4
|
I approve this submission. My approved PR: 507 |
Overlord-Runt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything cyao said plus can. your delete the gerber files. just leave gerber.zip as thats the important one.
Check off the following to let the reviewers know you've done everything:
[x] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[x] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[x] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[x] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[x] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[x] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION: