Skip to content

Conversation

@awfulcarpet
Copy link

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

Check off the following to let the reviewers know you've done everything:
[x] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[x] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[x] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[x] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[x] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[x] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:

  • Full render including all the parts
  • A few sentences about the inspiration and challenges
  • BOM
  • Photos of the Schematic, PCB, and case

If you're unsure about the format, make sure to check out this example and follow the format there.

If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!

@vercel
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2025 0:36am

Copy link
Contributor

@cheyao cheyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM #4

Copy link
Contributor

@danieliscrazy danieliscrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! It appears your PCB and your case are missing branding. All parts of your case must be branded. Once you've fixed this, I'll give you my approval!

@cheyao
Copy link
Contributor

cheyao commented Mar 16, 2025

I the branding on PCBs aren't required, since everyone is ordering it themselfs. Plus the ones on the case isn't required too if you are printing it yourself

@danieliscrazy
Copy link
Contributor

@cheyao Double checked the guide, you are correct on the PCB part, however as they've put the case on their BOM, they likely want it to be printed for them.
@awfulcarpet Please still put branding on your case.

add text branding on bottom of both cases
@awfulcarpet
Copy link
Author

@danieliscrazy There should be branding on both parts of the case. There is a small "gpad" indent on the bottom of both parts of the case.

Copy link
Collaborator

@Overlord-Runt Overlord-Runt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hihi, can you follow the repo structure here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants