Native crash in Node 10

[roblourens]

I installed Node 10 on MacOS and Win 10. Used it for various node things with no issues. But starting gulp always results in a native crash. Smells like a Node bug but I report it here because I haven't seen it anywhere else.

Same steps for Mac or Win...

• Have empty gulpfile.js
• Run gulp
• See crash output:

$ gulp
[21:08:45] Using gulpfile ~/code/gulptest/gulpfile.js
gulp[62193]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed.
 1: node::Abort() [/Users/roblou/.nvm/versions/node/v10.0.0/bin/node]
 2: node::InternalCallbackScope::~InternalCallbackScope() [/Users/roblou/.nvm/versions/node/v10.0.0/bin/node]
 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/roblou/.nvm/versions/node/v10.0.0/bin/node]
 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/Users/roblou/.nvm/versions/node/v10.0.0/bin/node]
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/roblou/.nvm/versions/node/v10.0.0/bin/node]
 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/roblou/.nvm/versions/node/v10.0.0/bin/node]
 7: 0x2ee39308427d
[1]    62193 abort      gulp

Same result if I run ./node_modules/.bin/gulp

What version of gulp are you using?
What versions of npm and node are you using?

$ gulp -v
[21:10:31] CLI version 3.9.1
[21:10:31] Local version 3.9.1
$ node -v
v10.0.0

If you can't reproduce this, I'm happy to debug more, but since I see it in 2 different environments, hopefully it's easy to reproduce.

[demurgos]

I tried the following configurations (using Linux):

Node	Gulp	Gulp-CLI	Empty gulpfile	Result (OK or Error)
9	4.0.0	2.0.1	No	OK
10	4.0.0	2.0.1	No	OK
10	3.9.1	2.0.1	Yes	OK
10	3.9.1	2.0.1	Yes	OK
10	3.9.1	3.9.1 (bundled)	Yes	OK

I am unable to reproduce your issue (see last line). The only difference is that I am using Linux instead of Mac or Windows.
Here is the project I used, is there a difference with your case?

Could you try to use Gulp 4.0.0 on your system and report if the error still happens? It would at least provide a mitigation for the issue.

The next step would be to locate the line actually causing the error: the Node dump is not very helpful unfortunately.

[AyushG3112]

@demurgos you should probably see nodejs/node#19786 and #2146 as these are related to this issue.

[yocontra]

@roblourens Did you run npm update to make sure you get the latest of your tree, and npm rebuild when you upgraded so any native modules already in your dependency tree would be recompiled?

[roblourens]

Yes I tried those things. From the other issues, sounds like I'm not the only one seeing this.

[yocontra]

@roblourens You're the only one who has reported this issue so far - those other issues linked were historical, and we resolved the issues in those prior to the release.

[MichaReiser]

I'm facing the same issue using Windows 10 and Node 10.
Deleted all node_modules folder after upgrading and ran npm rebuild.

yarn run v1.6.0                                                                                                                                                                                
(node:15548) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. 
$ yarn build:css && yarn build:vendor && yarn build:js                                                                                                                                         
(node:11116) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. 
$ cd css && yarn build                                                                                                                                                                         
(node:19200) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. 
$ gulp build                                                                                                                                                                                   
gulp build[14548]: src\node_contextify.cc:631: Assertion `args[1]->IsString()' failed.                                                                                                         
 1: node::DecodeWrite                                                                                                                                                                          
 2: node::DecodeWrite                                                                                                                                                                          
 3: uv_loop_fork                                                                                                                                                                               
 4: v8::internal::interpreter::BytecodeDecoder::Decode                                                                                                                                         
 5: v8::internal::RegExpImpl::Exec                                                                                                                                                             
 6: v8::internal::RegExpImpl::Exec                                                                                                                                                             
 7: v8::internal::RegExpImpl::Exec                                                                                                                                                             
 8: 000001B6AFD04281                                                                                                                                                                           

[stephenlacy]

I was unable to reproduce on macos with node 10 using @demurgos example.
I was using n not nvm to manage the versions. Can you download a node binary without using a version manager and try to reproduce the results?

[fishcharlie]

I'm having this same issue. You can see the Travis CI Output and the GitHub Repo.

[phated]

@fishcharlie @roblourens @MichaReiser nothing is going to be done on our side. Maybe you should bring this up with the node folks.

[roblourens]

Actually I can't repro with @demurgos' example. I can still repro with other projects, using the same gulp version, so I'm guessing the difference is some other dep in the package-lock.json. But this reproes even after npm update so I don't know what that would be.

[fishcharlie]

@phated It says a fix is in Gulp v4. I see a tag on GitHub for version 4, but it doesn't look to be released on NPM. Any updates on that front?

[roblourens]

Also using node from nvm vs normal binary makes no difference

[phated]

@roblourens there's a patch version of natives that needs to be updated. Check out what their latest version is and compare against your lockfile.

@fishcharlie news to me:

[fishcharlie]

@phated My bad. I was relying on the NPM detail page. I'm assuming that page just displays the latest version.