Fixes #4170 - Added analyzer that flags when user does not have Handled=true
#4182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Button.IsDefault
is confusing #4170Proposed Changes/Todos
Terminal.Gui.Analyzers
project (and tests).Accepting
does not sete.Handled = true
.Documentation
Note for the documentation, there is an established format:
https://github.com/dotnet/roslyn/blob/main/src/RoslynAnalyzers/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md
This format is actually enforced by compiler warnings and mismatches with diagnostic rules are detected. For this reason it makes sense to follow established best practice rather than have docs in our main docs dir (i.e. docfx).
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)