Skip to content

Fixes #2798. Add TrueColor support to CursesDriver. #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Oct 11, 2024
Merged

Fixes #2798. Add TrueColor support to CursesDriver. #3770

merged 32 commits into from
Oct 11, 2024

Conversation

@BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 30, 2024

Fixes

Proposed Changes/Todos

  • ncurses abstracts many of the terminal capabilities, but it does not natively support true color. To achieve true color, you can output ANSI escape sequences directly, while still using ncurses for other terminal control and interaction.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner September 30, 2024 23:54
@BDisp BDisp mentioned this pull request Sep 30, 2024
Merged
8 tasks
tig
tig approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

BDisp added 23 commits October 9, 2024 16:09
@BDisp
Fixes gui-cs#3784. SelfContained and NativeAot projects should use th…
8d09971 
…e local package in the release mode.
@BDisp
Run dotnet restore before build.
4afe694
@BDisp
Using local_packages folder for CI.
4288b71
@BDisp
Add build_release_consumer.
e130bfd
@BDisp
Remove build_release_consumer.
bd8ff63
@BDisp
Fix folder for CI.
5db3af9
@BDisp
Fix System.Text.Json vulnerability.
d77b899
@BDisp
Fix local_packageslocation.
3361eed
@BDisp
Add package sources to the packageSourceMapping tag.
f9f3431
@BDisp
Using the original configuration.
0dc3a52
@BDisp
Only add the Terminal.Gui pattern in the LocalPackages.
88e2ee6
@BDisp
Fix the path folder separator with unit style.
2c01b33
@BDisp
Using pack instead of build.
820bf44
@BDisp
Create LocalPackages Directory
d3192df
@BDisp
Add local_packages source.
ad69b9d
@BDisp
Using scripts to build release for NativeAot and SelfContained.
5b108a9
@BDisp
Trying to fix path.
0b4227b
@BDisp
Again.
a57db4e
@BDisp
Fix the path for the package,
c12a2cf
@BDisp
Need to build before pack.
214d109
@BDisp
Needs also build before pack locally.
29b902b
@BDisp
Fix build path.
3bcc34b
@BDisp
Merge branch 'v2_develop' into v2_2798_add-true-color-to-cursesdriver
bd307f7
@tig tig merged commit bc1aeaa into gui-cs:v2_develop Oct 11, 2024
4 checks passed
@BDisp BDisp deleted the v2_2798_add-true-color-to-cursesdriver branch October 11, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tig tig tig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TrueColor support to CursesDriver

2 participants

@BDisp @tig